search

Osmose / advanced-open-file

Open files and folders in Atom easily.
https://atom.io/packages/advanced-open-file
Other
119 stars 20 forks source link

Initial version of EditorConfig file added #122

Closed AlexWayfer closed 7 years ago

AlexWayfer commented 7 years ago

For 4-spaces indentation, LF and much more!

Osmose commented 7 years ago

Thanks for the PR!

I'm on the fence about this. We already have an ESLint config, and it has rules (that we don't currently have enabled, and I think eslint doesn't do anything by default now?) that should be able to cover most of thus, plus JS specific stuff that I think is important. And I'm not concerned about linting anything besides the JS stuff.

If you still want to add these checks, would you consider adding them to the eslint config instead?

AlexWayfer commented 7 years ago

Oh, okay. ESLint: that's why I closed #121 But .editorconfig set editor settings per-project if config file founded, as I know. It's not about linting, it's set Soft-Tab 4 in new file, even if in settings Tab 2, for example (as for me).

Osmose commented 7 years ago

Fair point. If I don't have editor-config installed it doesn't really affect me, I guess. Thanks!