search

Osmose / advanced-open-file

Open files and folders in Atom easily.
https://atom.io/packages/advanced-open-file
Other
119 stars 20 forks source link

"Move to the top" and "Move to the bottom" commands #123

Closed AlexWayfer closed 7 years ago

AlexWayfer commented 7 years ago

Closing #120

AlexWayfer commented 7 years ago

I don't understand why "checks have failed" 😞

AlexWayfer commented 7 years ago

Can you help me how I can run tests?

Osmose commented 7 years ago

Can you help me how I can run tests?

Sure! The Atom docs have a pretty good section describing how to run specs for a package.

Osmose commented 7 years ago

Thanks for the PR!

I've pointed out the two major things I noticed. I dunno why both tests are failing though, I'd only expect the first one to fail. Maybe the first one failing has some weird side effect making the second one fail? That's a little worrisome for our test isolation, but let's see what the tests say after fixing the other stuff first.

AlexWayfer commented 7 years ago

Thanks, man! You are awesome :) Sorry for that, it's my first PR to Atom plugin. Hope, helpful, and not the last.

Osmose commented 7 years ago

The tests pass, and this works! Thanks!

Now for the bad news that I only just now remembered: The current release of advanced-open-file is based on an old commit because this React-based stuff ended up not working properly when I initially released it. So while I can merge this into master, there are other bugs preventing me from releasing it. I'm really sorry for not remembering and mentioning it earlier.

The issues with the React-based stuff are significant enough that fixing them are not really feasible, so the best option I can think of (if you still want to add this to the released version) is to make a PR against the react-revert branch I just created and pushed. It's based off of the latest version, and any fixes you submit there I can release as soon as they get merged.

In the meantime, I'll still merge this, it's a great patch and worth including whenever the react stuff gets fixed up and lands. Thanks again!