Osmose / advanced-open-file

Open files and folders in Atom easily.
https://atom.io/packages/advanced-open-file
Other
119 stars 20 forks source link

popup path input is NOT wide enough. #140

Closed CodeAmend closed 7 years ago

CodeAmend commented 7 years ago

When I first installed this, it was wide and you can see the entire path, but since then I have installed new themes and now the width is like 25% of screen. This means that I cannot see the entire path. With Atom material it does not go off screen and as you add more paths it makes a new line to continue the large path. With isotope it does not. Perhaps you might say this is isotopes fault, but at least I would like to know what CSS is being afected so I can fix it myself. Thank you for such a nice package addition to Atom.

my setup: Atom 1.14.3 isotope ui

ISOTOP UI (this does not play nice)

ATOM MATERIAL UI

alvis commented 7 years ago

I have similar issue with Dark Flat UI. For this theme, the cause is that the theme introduces a max-height to atom-text-editor[mini]. I think the reason should be similar for Isotope. A quick fix is to overrule the style specifically for the path input. Here is my code injected to Atom's stylesheet:

atom-panel div.advanced-open-file atom-text-editor.path-input {
  max-height: none;
}

This style would not target anything else but the path input box. So it is more-or-less a perfect solution, except the fact that you've to inject the code yourself. Probably it is good for advanced-open-file to include this css into the package.

CodeAmend commented 7 years ago

Thanks for the response! Unfortunately, I was not successful with your method. I hope the author can take a look at this. This is an actual bug.

iamstarkov commented 7 years ago

@CodeAmend can you change the theme?

iamstarkov commented 7 years ago

and see if it works with other themes?

iamstarkov commented 7 years ago

i wouldnt say its actual bug, as far as it depends on a theme you use

NDuggan commented 7 years ago

@alvis suggested CSS didn't work for me either, but it was close.

@CodeAmend To get it to work with my active theme (Nucleus Dark) I used the following:

// Fix advanced-open-file input width
atom-panel div.advanced-open-file atom-text-editor.path-input {
  height: auto;
}
cavaunpeu commented 7 years ago

@alvis solution worked for me. Using Atom Dark.

RodideBoer commented 7 years ago

I have the same with Atom Dark theme. It is pretty annoying. Workaround by @alvis works, but it is pretty lame to have the input box grow vertically like that. It would be better if the input box would just scroll to show the caret (where you're typing).

CodeAmend commented 7 years ago

I agree with the scroll idea! +1

On Sat, Apr 29, 2017 at 10:19 AM, Rodi de Boer notifications@github.com wrote:

I have the same with Atom Dark theme. It is pretty annoying. Workaround by @alvis https://github.com/alvis works, but it is pretty lame to have the input box grow vertically like that. It would be better if the input box would just scroll to show the caret (where you're typing).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Osmose/advanced-open-file/issues/140#issuecomment-298175226, or mute the thread https://github.com/notifications/unsubscribe-auth/ALoku2DcbM2qLwSOmfFq6l2y1XJ0jtlOks5r01UVgaJpZM4MNRgq .

tbondarchuk commented 7 years ago

Looks like scroll has been implemented :) atom 1.17.0 advanced-open-file 0.16.6 native-ui 0.20.6

NDuggan commented 7 years ago

Can confirm scroll is working for me in Atom 1.17.0 (before and after removing the suggested CSS fix above).

Great work!

RodideBoer commented 7 years ago

It seems to work here too. Had to double check, because I didn't see the caret, but after starting to type it did scroll to the end. Could use a little bit of extra white space at the end , but it works!

Good job people.

iamstarkov commented 7 years ago

so issue can be closed? @CodeAmend

Osmose commented 7 years ago

Sounds like it based on the reports. Sorry for not spending time fixing this; I haven't made time for AOF in a while. But hooray for the problem fixing itself!

Feel free to reopen if this isn't fixed for you. Thanks!

CodeAmend commented 7 years ago

Sorry for not answering, I didn't realize I had a message. I cannot reproduce this right now. But, because this is such an amazing plugin, I will let you know if I get another conflict.