search

Osmose / advanced-open-file

Open files and folders in Atom easily.
https://atom.io/packages/advanced-open-file
Other
119 stars 20 forks source link

Hide files with given glob patterns #150

Closed econtal closed 6 years ago

econtal commented 6 years ago

This MR allows to hide certain files in the list, using their extension. Example: hides .pyc files.

Osmose commented 6 years ago

Thanks for the PR! Reviewing this is in my todo list, I'll get to it when I can. :D

econtal commented 6 years ago

Thanks for the suggestions. I updated the PR which now uses glob patterns instead of suffixes. It uses minimap as a backend to compute the matching. The Minimap objects are compiled once and then cached to optimize performances.

econtal commented 6 years ago

Hi @Osmose: please let me know, when you have time, if you have other suggestions!

econtal commented 6 years ago

Sorry for this delay before updating the PR. I appreciated the above comments and did my best to address them. Thanks for the ideas!

Osmose commented 6 years ago

Thanks for this! I realized I totally forgot to mention tests and will add one or two before merging this, and will do a release shortly after.

Osmose commented 6 years ago

Should be out now: https://github.com/Osmose/advanced-open-file/releases/tag/v0.16.8

pdxwolfy commented 6 years ago

Nice feature!