Osmose / advanced-open-file

Open files and folders in Atom easily.
https://atom.io/packages/advanced-open-file
Other
118 stars 20 forks source link

[WIP] prompt confirmation before opening a new file #154

Closed econtal closed 5 years ago

econtal commented 6 years ago

Current issue

It's pretty common to unintentionally open a new file instead of an existing one. A typical use case is when typing [tab] then immediately [enter] without checking that [tab] didn't auto-completed the entire filename. Closing the opened new file is then "slow" because it prompt a native "confirmation" splash screen ("don't save", "cancel", "[save]").

Proposal

Require a quick confirmation before opening a new file. The current proposal is to type [enter] twice. The first [enter] beeps. I'm using the WIP implementation from this PR for months, and I'm confident it's satisfying from a user point of view:)

UI Discussion: prompt message

I haven't implemented any message to the user asking for confirmation. I would like to open a discussion on where would be the best place for this message:

TODO

Osmose commented 6 years ago

Thanks for filing this!

I like this a lot. I think Option A, maybe with making the text green-colored when creating a file, would be best. The text could be "File does not exist; hit [shortcut] again to create it." It should probably also say "folder" when creating a folder instead of a file.

I'm at a workweek all this week so I won't be able to look at this PR or any updates you post, but I'll add a reminder for myself to look at it next week.

Osmose commented 5 years ago

Closing as it's been almost half a year since any activity. Feel free to resubmit an updated PR. Thanks!