Osmose / advanced-open-file

Open files and folders in Atom easily.
https://atom.io/packages/advanced-open-file
Other
118 stars 20 forks source link

Rewrite package in ES6 #17

Closed Osmose closed 9 years ago

Osmose commented 9 years ago

I'm not a huge fan of Coffeescript personally, and I'm also not a huge fan of how space-pen does things. I also keep finding features that made sense for advanced-new-file that don't for advanced-open-file.

I think I'd like to try porting/rewriting the package to ES6 using the 'use babel' hook for running the code through Babel. I'm not sure what I'd replace space-pen with, but one possibility is React. There's an NPM package called react-for-atom that a bunch of Facebook's Nucleide libraries depend on which seems interesting. On the other hand, React might be a bit overkill compared to a simpler library like space-pen. We'll see!

Osmose commented 9 years ago

I've got an 80% of the way there branch going on, and while I like ES6 over CoffeeScript, I dunno about React. What with the amount of other issues being filed, I'm thinking maybe I should just try and refactor the existing CoffeeScript instead to remove the CoffeeScript-isms that I'm not a fan of. Hmmm.

Osmose commented 9 years ago

Yeah, I think refactoring but keeping CoffeeScript and space-pen is best for now.