search

Osmose / advanced-open-file

Open files and folders in Atom easily.
https://atom.io/packages/advanced-open-file
Other
118 stars 20 forks source link

Difference Unix/Windows paths for adding project folders #30

Closed traverse closed 9 years ago

traverse commented 9 years ago

Hey I just noticed a small difference between Unix and Windows paths for adding project folders so I made some screenshots because they show exactly what I mean.

windowspath unixpath

So basically with a standard Windows path the plus doesn't show with a Unix path it does.

advanced-open-file 0.9.1 Atom 1.0.11 Windows 7 x64

Osmose commented 9 years ago

Thanks for the report!

I have a branch up at https://github.com/Osmose/advanced-open-file/tree/detect-folders-better with a possible fix but no easy way to test it. Could you verify if it works or not?

traverse commented 9 years ago

Hey I just tested it and I'm not sure what the intended behavior is now. Is it intended that you can't add folders inside the current project folder as a new project folder? If so then this fix works if that's not the intended behavior then this fix breaks it for both Windows and Unix paths so depending on what the intended behavior is I can't say at the moment if it's fixed or not.

Osmose commented 9 years ago

Is it intended that you can't add folders inside the current project folder as a new project folder?

It is, because you used to be unable to add subfolders of project folders as new project folders. However, I just tested it and it seems to work now, so I'll followup with another fix to remove the logic that detects that.

Thanks for verifying!

Osmose commented 9 years ago

Merged. The fix should go out soon after I do a release within the next day or two. Thanks for the testing and report!

(And I filed https://github.com/Osmose/advanced-open-file/issues/38 about showing the buttons on folders that can now be added as project folders.)