search

Osmose / advanced-open-file

Open files and folders in Atom easily.
https://atom.io/packages/advanced-open-file
Other
118 stars 20 forks source link

Introduce C-l to strip dir-components, and fix scroll #44

Closed artagnon closed 8 years ago

artagnon commented 8 years ago

I can't test this: feel free to either modify and commit, or help me fix #42.

Thanks.

artagnon commented 8 years ago

Fixed. Works now, please pull if happy.

Osmose commented 8 years ago

Cool, thanks for the PR!

I'll try to take a look at this soon, sometime this weekend at the latest.

artagnon commented 8 years ago

I just made another update to it. Should be perfect now.

Thanks, no rush.

Osmose commented 8 years ago

This looks pretty good! Tested it locally and it totally works. Nice work!

Let me know when you push up another version and I'd be happy to confirm it's good and merge it in. Afterwards I'll add some docs for the new keybinding and add you to the CONTRIBUTORS file. :D

artagnon commented 8 years ago

Thanks for the detailed review! I've pushed out a new version; let me know if I've missed something.

artagnon commented 8 years ago

Okay, another iteration. This time, I found that confirm-selected-or-first is more useful than the original confirm-selected-or-only (simply amended your commit). Also got around to writing documentation for delete-path-component finally.

Like it?

Osmose commented 8 years ago

I'm fine with the change to confirm-selected-or-first, but it really belongs in a separate PR from this one. Could you split it off?

(I'll be spending some time on the project tomorrow afternoon so I'll get to reviewing and stuff like that then, thanks for the patience!)

Osmose commented 8 years ago

Looks great, nice work! Thanks again for the contribution. :D