Closed artagnon closed 8 years ago
Fixed. Works now, please pull if happy.
Cool, thanks for the PR!
I'll try to take a look at this soon, sometime this weekend at the latest.
I just made another update to it. Should be perfect now.
Thanks, no rush.
This looks pretty good! Tested it locally and it totally works. Nice work!
Let me know when you push up another version and I'd be happy to confirm it's good and merge it in. Afterwards I'll add some docs for the new keybinding and add you to the CONTRIBUTORS
file. :D
Thanks for the detailed review! I've pushed out a new version; let me know if I've missed something.
Okay, another iteration. This time, I found that confirm-selected-or-first is more useful than the original confirm-selected-or-only (simply amended your commit). Also got around to writing documentation for delete-path-component finally.
Like it?
I'm fine with the change to confirm-selected-or-first
, but it really belongs in a separate PR from this one. Could you split it off?
(I'll be spending some time on the project tomorrow afternoon so I'll get to reviewing and stuff like that then, thanks for the patience!)
Looks great, nice work! Thanks again for the contribution. :D
I can't test this: feel free to either modify and commit, or help me fix #42.
Thanks.