Promise.defer causing crashes with other packages

Osmose / advanced-open-file

Open files and folders in Atom easily.

https://atom.io/packages/advanced-open-file

Other

118 stars 20 forks source link

Promise.defer causing crashes with other packages #68

Closed JaKXz closed 8 years ago

JaKXz commented 8 years ago

It seems that advanced-open-file polyfilling the global.Promise object is breaking other packages, namely atom-typescript. See: TypeStrong/atom-typescript#709

Osmose commented 8 years ago

Oh shiiiiiiii

Thanks for the report! Guess we can't use the Babel polyfill directly. Oh well!

JaKXz commented 8 years ago

Thanks!

Osmose commented 8 years ago

@NoctisHsu This fixes the issue for me, can you confirm if this fixes it for you as well? I just released 0.12.1 with the fix.

NoctisHsu commented 8 years ago

@Osmose Yes, It's working fine with atom-typescript package now. Thanks a lot :)

Osmose commented 8 years ago

No problem, glad to help. Thanks for verifying. :D