search

Osmose / advanced-open-file

Open files and folders in Atom easily.
https://atom.io/packages/advanced-open-file
Other
118 stars 20 forks source link

Fix #72: Calculate modal max-height. #74

Closed Osmose closed 8 years ago

Osmose commented 8 years ago

Also fixes an issue with themes mucking with z-indexes such that you can't click the modal.

@Traverse Does this solve your issue?

Note that this intentionally doesn't handle the edge case of resizing the window while the modal is open because it'd be a bit complex to update automatically (and would cost some CPU by possibly triggering reflows during the resize event) and probably just won't happen often enough to matter.

traverse commented 8 years ago

@Osmose This does solve my issue, thanks a lot! Also this branch solves the error in #50 with hiberfil.sys so double win :+1:

Osmose commented 8 years ago

np, thanks for the verification!