Nitpicking pixels on input field.

Osmose / advanced-open-file

Open files and folders in Atom easily.

https://atom.io/packages/advanced-open-file

Other

118 stars 20 forks source link

Nitpicking pixels on input field. #79

Closed jesseleite closed 8 years ago

jesseleite commented 8 years ago

I notice a few really small styling inconstancies with advanced-open-file's input field, versus other input fields in Atom (ie. Command Palette, CMD-F find and replace, etc.)

Advanced Open File: example

Command Palette: example2

Also, the border on the left and right of the input seems thinner.

I inspected your styles, and I notice you're using flex. I'm not much help as I don't know much about flex, otherwise I'd submit PR.

Sorry for nitpicking pixels here :D I really do love this package... Thank you for all your work <3

Osmose commented 8 years ago

omg is this why there's that gap below the cursor

can i really finally get rid of that

yesssssssssss

(Thanks for the report!)

jesseleite commented 8 years ago

Haha :) Not sure if flex is affecting that border width on left and right as well? Do you see what I'm talking about there?

Osmose commented 8 years ago

Should be fixed in master. I'm not 100% sure why a flex value of 0 was the solution, but it was. Oh well!

Will try to make a release within the next week or so that will include the fix. Thanks again for filing the issue. :D

jesseleite commented 8 years ago

No problem, and thank you :)