Osmose / advanced-open-file

Open files and folders in Atom easily.
https://atom.io/packages/advanced-open-file
Other
118 stars 20 forks source link

Add an advanced-open-file service? #88

Open bronson opened 8 years ago

bronson commented 8 years ago

Is there any chance advanced-open-file could provide an open file service? The service would accept a path, then display the dialog and behave exactly as it does now.

I'd like this because Rails-Transporter prompts for a file if one doesn't exist:

https://github.com/hmatsuda/rails-transporter/blob/be5a0e45c5ec5dd5708e64f6b10edc95d5cc8263/lib/file-opener.coffee#L290-L298

It feels really familiar, but doesn't have autocompletion, directory creation, or any of the other nice advanced-open-file features.

If the service exists, rails-transporter could use the advanced file opener. Otherwise, it would fall back to its built-in.

Osmose commented 8 years ago

Thanks for the suggestion!

Now that I know about services, I'm a little more interested in this than when a similar idea was previously suggested. It'd be neat to make advanced-open-file a wrapper around the service for basic file operations, and allow other plugins to use it.

I'll think about this. I'm hoping to spend some time this weekend on advanced-open-file, but we'll see if that pans out. :D

Osmose commented 8 years ago

Thinking on this more, I'd be willing to review a patch for this, but I'm not interested in working on it myself. It's a fairly heavy change and it's unclear just how many other packages would be interested in it and whether it'd be worth the time.

If someone wants this and submits a PR, though, I'd totally be down. It's a neat suggestion!

bronson commented 8 years ago

Makes perfect sense. Not sure I can get to it either... I'll close it in a few weeks if I can't shake the time loose.