search

Osmose / advanced-open-file

Open files and folders in Atom easily.
https://atom.io/packages/advanced-open-file
Other
118 stars 20 forks source link

UI elements shifted to inconvinient position #92

Closed schiegl closed 8 years ago

schiegl commented 8 years ago

This was not always the case. About 5 updates ago it was still showing correctly but now the first folder interferes with the input box.

fileopen

Is it also possible to have a little more top margin at "Enter the path for the file to open or create"?

I managed to do that just by adding change those 2 CSS classes. But apparently you haven't noticed it so it might break your UI.

.advanced-open-file {
    display: flex;
    flex-direction: column;
    overflow: hidden;
    z-index: 100;
    margin-top: 5px; // added this

    ...
    ... other css code
    ...

    .list-group {
        overflow: auto;
        flex: 2;
        position: relative;
        margin-top: 16px; // added this
    }

    ...
    ... more css
    ...

}
Osmose commented 8 years ago

Thanks for the report!

Can you share which theme you're using? It'd help me reproduce and test these changes.

schiegl commented 8 years ago

UI Theme is Atom Material and Syntax Theme is Gruvbox

jamby commented 8 years ago

Yeah I, too, am using Atom Material theme and this is happening to me. Looks like the "text area" is lower than it should be too. It's too far below the "+ Enter the path ...".

Osmose commented 8 years ago

I just tried to replicate this and failed; it looks fine to me (in terms of the textarea, the padding at the top is still awkward and I'm trying to figure out if there's a theme variable I can take advantage of for that). I'm on OSX El Capitan, what platforms are ya'll on?

jamby commented 8 years ago

I'm also on OS X El Capitan.

screen shot 2016-02-22 at 10 29 47 am

This is how mine looks, without the styling.

jamby commented 8 years ago

@Osmose This actually seems to be fixed in the latest update to the Material Theme.

Osmose commented 8 years ago

@Osmose This actually seems to be fixed in the latest update to the Material Theme.

Yeah. I wanted to see about fixing the weird spacing at the top but ran into issues because the theme now has specific fixes for this package that are adding some padding that was interfering. I think I'll just call this fixed, I'm fine with themes having their own fixes; working for every theme is too difficult for me otherwise.

Thanks again!