Show git status for files

keskiju commented 8 years ago

It would be nice if advanced-open-file would show git status for added and modified files just like the tree-view does.

Osmose commented 8 years ago

Oh, I like this one. Thanks for the suggestion!

I think this should be behind a default-off preference. Otherwise, I approve! :D

Osmose commented 8 years ago

Looked into this briefly earlier this week. I still need to confirm whether Atom's built-in Git support that's available to packages can work on projects that aren't open as Project folders; if not, I think I'll limit this to in-project files, but also if that's the case I'm open to making this a default-on preference.

Also I suspect this will take a bit of restructuring to do (mainly because I think we'll have to start keeping track of the parent directory of paths in the path list, which we don't currently do), but that'd be a smart thing for us to do anyway.

Osmose commented 8 years ago

Made some progress on this: https://github.com/Osmose/advanced-open-file/compare/git-status

My thoughts:

We can, in fact, get the git status of projects that are not currently loaded as project folders.
Getting git status is async; the current UI rendering stuff is all sync, which makes adding this a bit finnicky. I'd recommend fixing #56 before tackling this.
Getting git status seems slow in many cases. I suspect that the node_modules folder in my local checkout is large enough to be causing the slowdown. Tree-view seems way snappier than my test code though, so I'm probably doing something dumb. Tree-view also updates the git status in an asynchronous way. Basically sync stuff is evil and our UI suffers for it. Hooray!

The time I have / want to give for this project will probably shift towards base async work vs this particular feature, but that time is also small. If someone wants to beat me to the punch, I'm more than happy to review PRs with fixes to the async issues and this feature. :D

Osmose / advanced-open-file

Show git status for files #94