search

Osthanes / deployscripts

Deployment scripts for IBM Container Service. Used as example scripts in the Pipeline to aid in continuous deployment of an application
Other
6 stars 35 forks source link

Container route by default #60

Open jesusmah opened 8 years ago

jesusmah commented 8 years ago

Hi there,

I am an IBM Cloud Solution Engineer working directly with IBM clients in the microservices world. So far, the majority of container-based solutions clients go for are those where containers are not publicly exposed since that is one of the bigger advantages with CF solutions. Thus, more than 90% of the containers deployed in BMX (for these client solutions) will not have a public route.

We would like that the option IGNORE_MAPPING_ROUTE is more present in the script/documentation so that clients are aware of this option without needing to dig into the code.

Thanks

nfritze commented 8 years ago

The option was added specifically for this case, by request of a particular user/customer. That said, as far as we can tell, its usage has been pretty sparse. We can look at expanding the comments on it, but you're also welcome to do so yourself and submit back a pull request with the changes. Happy to accept things like that :)