Fixed the `eatRID` method when RID is negative

Ostico / PhpOrient

PhpOrient - Official Php driver based on the binary protocol of OrientDB.

Other

68 stars 37 forks source link

Fixed the `eatRID` method when RID is negative #70

Closed ihortymoshenko closed 7 years ago

coveralls commented 8 years ago

Coverage remained the same at 73.051% when pulling f2ab562151d7126c12f9b8d1d2cf60f2a71a3c6d on IgorTimoshenko:hotfix/negative-rid into 71992267d442339b166d6715d2ac8fac3fb195fd on Ostico:master.

Ostico commented 8 years ago

Hi @IgorTimoshenko , i think that you have found some bug with 32bit PHP version on decoding RID because it is not possible to have a negative RID. Can you provide some code to reproduce the issue and a test also?

ihortymoshenko commented 8 years ago

@Ostico, negative RID is a temporary RID. In my case it appears in some select queries with the let keyword

Ostico commented 8 years ago

@IgorTimoshenko tnx, so i supppose this is a right behaviour, tnx for the PR, i will merge.