Ostico / PhpOrient

PhpOrient - Official Php driver based on the binary protocol of OrientDB.
Other
68 stars 37 forks source link

ERROR with OrientDB 2.2 #71

Closed stefpe closed 8 years ago

stefpe commented 8 years ago

When I started to use this driver with OrientDB 2.1.* everything is working as it should, but with 2.2 it breaks because of Protocol version 34 is not supported.

Actually the solution is really simple, you need to pass the protocol version from your constants "32" during the two connect commands(server and database) and everything works.

I just removed these lines in OrientSocket Class, and now the constant protocol version was automatically transmitted in the both connect commands.

if( $protocol > $this->protocolVersion ){ throw new PhpOrientWrongProtocolVersionException('Protocol version ' . $protocol . ' is not supported.'); } $this->protocolVersion = $protocol;

Can you please fix this, because I really want to work with the newest version coming up.

Thank you in advance.

andreyvk commented 8 years ago

@stefpe this might not be as easy as just switching a value to 34 or even worse - removing a line that sets the protocol version internally in the library. New protocol engine from Orient might contain improvements/changes that might lead to wrong record handling and screw you DB at some point. So be careful ))

@Ostico needs to take a more thorough look I guess. I'm also looking forward to getting this new feat.

smolinari commented 8 years ago

Couldn't you just run the unit tests and if they pass, the protocol could be considered "functional" and more importantly, safe to use? The only possible problem after that is, the driver might not be introducing any additional/ new features added to protocol 34. But, at least you'd know the driver still works properly with 2.2. Right?

Scott

andreyvk commented 8 years ago

@smolinari very true. Forgot about them tests completely ))

stefpe commented 8 years ago

I forked the project, changed the code and tried with version 2.1.* -> everything works! Tried with version 2.2.0RC1 -> fails for tokens and some sql command tests.

smolinari commented 8 years ago

Ok. That would mean @Ostico would need to dig in and make the driver 2.2 ready. :smile:

Scott

luclanet commented 8 years ago

+1

RedactedProfile commented 8 years ago

+1 very excited to use 2.2, but the driver need to support it :(

Ostico commented 8 years ago

Upgrading. The protocol changed significantly and some issues on documentation slowed work. Will be updated as soon as possible. I apologize for the delay.

andreyvk commented 8 years ago

+1 for the update! woohoo!

SimonSoftware commented 8 years ago

+1 for the update

GNSPS commented 8 years ago

+1 for the update

mamoit commented 8 years ago

@Ostico Any news on the 2.2 compatibility?

Ostico commented 8 years ago

Hi all. I started to work on that, but this month i'm really busy. I only upgraded the python driver at moment. I can continue starting from Wednesday.

andreyvk commented 8 years ago

@Ostico thanks for the reply. Eagerly waiting on the update. Good luck!

smolinari commented 8 years ago

@Ostico - If you need any support with documentation, doc proof reading, simple PHP programming tasks, please let me know.

Scott

RedactedProfile commented 8 years ago

@Ostico similar, willing to offer help with the php driver, just let me know of a task or two that could help ease your load

GNSPS commented 8 years ago

@Ostico same here!

SimonSoftware commented 8 years ago

@Ostico me too!

RedactedProfile commented 8 years ago

a week later, any further update? Thank you

cheers

metehan commented 8 years ago

Today i tried to upgrade to 2.2 i also faced with this issue.

Waiting is not best thing but it's nice to see we have some community here, and i am not alone :)

Ostico commented 8 years ago

Updated