search

Ostico / PhpOrient

PhpOrient - Official Php driver based on the binary protocol of OrientDB.
Other
68 stars 37 forks source link

don't continue if input is empty #87

Closed bazo closed 7 years ago

bazo commented 7 years ago

this avoids errors on php7

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.08%) to 70.808% when pulling a1b9b30f906186fa25518d4499f180c966a34114 on bazo:serialization-return into 8a2b7099db2c86c48bc6e756fc929eea682f51cc on Ostico:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-4.2%) to 67.718% when pulling a1b9b30f906186fa25518d4499f180c966a34114 on bazo:serialization-return into 8a2b7099db2c86c48bc6e756fc929eea682f51cc on Ostico:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-4.2%) to 67.718% when pulling a1b9b30f906186fa25518d4499f180c966a34114 on bazo:serialization-return into 8a2b7099db2c86c48bc6e756fc929eea682f51cc on Ostico:master.

Ostico commented 7 years ago

This patch breaks the integer deserialization:

https://github.com/Ostico/PhpOrient/blob/master/tests/PhpOrient/Serialization/DecoderTest.php#L29

You should return [ $collected, $input ]

I will patch it.