search

Ostoic / RaidBrowser

Bringing LFR to Wrath of the Lich King (Non-Classic)
MIT License
36 stars 19 forks source link

fix lua exception on showing tooltip #24

Closed MassCraxx closed 1 year ago

MassCraxx commented 1 year ago

Closes #23

MassCraxx commented 1 year ago

I just realized I also pushed my removal of the double click listener (had it because I personally am not a fan of this functionality). If you want to preserve that method re-add button:SetScript("OnDoubleClick", on_join) in L145.

Ostoic commented 1 year ago

The changes look good to me and it works well! It passed 15/189 of the unit tests, which is the same as before f5e8c29 (not that I expected it to). I think the double click behavior can be annoying if you accidentally double click and are forced into an undesirable social situation. I greatly appreciate the work.