Ostoic / RaidBrowser

Bringing LFR to Wrath of the Lich King (Non-Classic)
MIT License
36 stars 19 forks source link

Fix/localized clients #26

Closed MassCraxx closed 1 year ago

MassCraxx commented 1 year ago

Currently localized clients (using any language other than enUS) run into some problems using the AddOn:

These changes should solve these issues making sure a predefined Class-Spec name is used for the join message and using a translation lib to compare localized raid names. Unfortunately comparing Raid IDs seems not to be possible so I assume this is the best solution.

Please note I also adjusted the join message a bit ("LFG icc25 - 5857gs Discipline Priest") - I hope we will find a solution to adjust it in-game in the future.

Ostoic commented 1 year ago

This will be a good change for non enUS users.

With regards to your last point, I was thinking of adding AceConfig to improve the UX. From what I recall, this will add a section to the AddOns tab in the Interface frame and we can put an input box for the join message, perhaps with support for RaidBrowser parameters ($achieve or %achieve%, $class, etc). I also believe changing the OnDoubleClick click behavior for joining raids should be configurable, as some people (https://github.com/Ostoic/RaidBrowser/pull/27#issue-1561274099) liked that feature.

In any case, I'll have to test these changes first before accepting the pull, so give me a few hours at the minimum. Thanks again!

Ostoic commented 1 year ago

The only problem I see with this form of the join message is that people with chat addons that highlight the words "inv" or "invite" won't benefit from convenient click-invites anymore. I think I'd like to keep this the way it was originally and then allow for custom join messages using the above-mentioned config frame. If you could revert that change then I will accept the pull.