search

Ostoic / RaidBrowser

Bringing LFR to Wrath of the Lich King (Non-Classic)
MIT License
36 stars 19 forks source link

feat: spec detection, new raids, dualspec, bugfix #27

Open jozefmutis opened 1 year ago

jozefmutis commented 1 year ago

Added:

Fixed:

Ostoic commented 1 year ago

Note that I decided to change the OnDoubleClick behavior as discussed here because to me it seemed to be a more sane default. My plan is to introduce AceConfig to make this configurable for those who prefer it.

Otherwise, this looks like another great addition! I'll have to do some testing with these changes to make sure everything still works smoothly, but I plan to merge it later today or tomorrow.

Thanks again.

MassCraxx commented 1 year ago

These are great additions! Hope they will be merged soon.

Maybe put the refresh time on 90s instead of 120s to prevent too much clutter. And not sure if "toGc10hc" isn't too much: doesnt togc already imply its hc? So imo it should be either togc10 or toc10hc...

MassCraxx commented 1 year ago

Because of the heavy recent changes on master, the merge conflicts got pretty big. @Ostoic If you want help with this, I went ahead and solved them here: https://github.com/MassCraxx/RaidBrowser/tree/pr/qol-improvements

I don't want to create another PR tho, if I do @jozefmutis would not be credited for his additions.

MassCraxx commented 1 year ago

Bump, please merge.

xxxkowal commented 1 year ago

bump, merge please

xxxkowal commented 1 year ago

I do it myself and when i double click on togc10-25/toc10-25, addon link the best addon "First realm gran crusader" XD I dont have that achiv, can u fix this? @jozefmutis

DimaSheiko commented 5 months ago

@jozefmutis Do you know if this is currently usable?

MassCraxx commented 5 months ago

@jozefmutis Do you know if this is currently usable?

@DimaSheiko Alternatively try this merged and fully tested version here: https://github.com/MassCraxx/RaidBrowser/tree/pr/qol-improvements

DimaSheiko commented 5 months ago

@jozefmutis Do you know if this is currently usable?

@DimaSheiko Alternatively try this merged and fully tested version here: https://github.com/MassCraxx/RaidBrowser/tree/pr/qol-improvements

Nice, thank you! Are you planning to implement improvements in your fork?

MassCraxx commented 2 days ago

@jozefmutis Do you know if this is currently usable?

@DimaSheiko Alternatively try this merged and fully tested version here: https://github.com/MassCraxx/RaidBrowser/tree/pr/qol-improvements

Nice, thank you! Are you planning to implement improvements in your fork?

yes, I will continue development from time to time here https://github.com/MassCraxx/RaidBrowser/tree/dev