search

OsuSync / RealTimePPDisplayer

A Sync Plugin, calculate and display your Osu game data in real time.
MIT License
103 stars 16 forks source link

PP displayer for 100% is inconsistent #27

Closed Ztumpie905509 closed 5 years ago

Ztumpie905509 commented 5 years ago

The PP displayed between the choose-song menu and final results is inconsistent.

Take Now Loading!!!! [Extra] by doormat as an example,

The pp showed in the Choose-song menu for 100% is 252.90pp screenshot085

However, when I use Auto mod to spectate the map, the bot scored it 100% but the pp showed is 251.11pp instead of 252.90pp screenshot084

May I ask which value (251.11pp or 252.90pp) is more accurate ? Maybe also fix the inconsistent problem ?

KedamaOvO commented 5 years ago

Make sure "Listen interval" is a suitable value.

If it is too long, RTPPD may not be able to calculate the last pp. (pp calculation only works in the Playing state)

                         Timeline
+------------------------------+--------------------------+
|               Playing        |          Rank            |
|                              |                          |
|            T1    T2    T3  T4|                          |
|            |     |     |   | |                          |
| OSU      +-+-----+-----+---+----------------------+     |
|              PP1   PP2   PP3 |  Final PP(No calculation)|
|              |     |     |   |  |                       |
| RTPPD    +---------------+------+-----------------+     |
|              ^     ^         |                          |
|              +--+--+         |                          |
|                 |         Only working at Playing       |
|            Listen Interval                              |
+---------------------------------------------------------+
Ztumpie905509 commented 5 years ago

I think this is a default value as i never touched it.

Annotation 2019-03-09 175456

For the length of the song, it is just 01:27, i don't think this is too long.

KedamaOvO commented 5 years ago

Thanks for your report, I have fixed it. https://github.com/OsuSync/RealTimePPDisplayer/releases/tag/v1.6.9

Ztumpie905509 commented 5 years ago

The issue was fixed in version 1.6.9, but still remains in 1.6.10 Please update this.