search

OtagoPolytechnic / Renewify

Renewify is a puzzle game made for third year "Studio 5/6" paper at Otago Polytechnic
https://mckeld3.itch.io/renewify
4 stars 1 forks source link

Thicker Grid Border #65

Closed LiamMcKenzie closed 6 months ago

LiamMcKenzie commented 7 months ago

Linked to issue #63

LiamMcKenzie commented 7 months ago

I've added 10 x 0.1 tiles to the outside of the grid to add a border. This is currently hard set for a 10x10 grid, and will need to be changed later with code grid 1 The grid looks more consistent now grid 2

LiamMcKenzie commented 7 months ago

Border now resizes to match gridsize

Capture7

LiamMcKenzie commented 7 months ago

Code Review

Functional Requirements

Is the application fit for purpose? Does it meet the user’s requirements and properly address the issue?

  • Code works well and reliably works no matter what grid size.

Legibility and Style

Uses agreed coding standards/conventions? Readable, consistent and well-structured with useful comments?

  • Do the variables on lines 13 and 14 need to be public or can they be set to private?

Any repetitive code that could be refactored? (DRY)

  • Code is DRY

Correctness of the Code

Is the code reliable, giving same results every time it runs? Does it function correctly?

  • I couldn't find any errors or inconsistencies.

Implementation

Any notable performance/speed issues? Compatibility and Responsiveness on other platforms ?

  • All looks good.

Final Comments

  • Great feature. All working well and it looks much better with the extra line.

no the variables didn't need to be public