Using async http requests for get-updates and polling;

Otann / morse

📡 Clojure interface for Telegram Bot API

Eclipse Public License 1.0

257 stars 48 forks source link

Using async http requests for get-updates and polling; #33

Closed dixel closed 6 years ago

dixel commented 6 years ago

Adding global timeout outside of the API call implementation;
Stopping polling in case of any issue - delegating retry logic to the application;

Overall this changeset tries to consolidate all potential errors that could happen during the polling process and delegate their handling to a user application (maybe I am missing some potential use-cases for a library-level retry and circuit-breaking logic). The way tests are handled can be improved if this issue gets resolved.

dixel commented 6 years ago

Please go ahead with merge and suggested changes, seems very beneficial to have a consistent vision on the error propagation topic.