Oteemo / charts

Helm chart repository
https://oteemo.github.io/charts
MIT License
181 stars 234 forks source link

sonarqube: fix #250 #251

Closed tigran-a closed 3 years ago

tigran-a commented 3 years ago

Restore plugin directory mount behaviour as in v9.2.6 and before, in case of no persistence enabled.

rjkernick commented 3 years ago

This doesn't quite look like a rollback. File used to look like this: https://github.com/Oteemo/charts/pull/245/files

tigran-a commented 3 years ago

It is not a complete rollback. The problem happens now only when using no persistence. This patch uses the previous behaviour (mount extensions/downloads to an ephemeral volume) when no persistence is set, and a "new" one when the deployment is done with persistence (then we mount complete extensions directory, instead of its subdirectory).

gvrf2911 commented 3 years ago

This PR does not fix the case when we use both plugin installation by the HELM and persistence.

I think it is also the case of the people of the issue #255.

In my case, persistence is not used for plugins (and I don't have encounter the issue #245) but for ES data.