search

Oteemo / charts

Helm chart repository
https://oteemo.github.io/charts
MIT License
181 stars 234 forks source link

Add securityContext to wait-for-db initContainer like the other initContainers #290

Closed lepouletsuisse closed 2 years ago

lepouletsuisse commented 3 years ago

Sonarqube Helm Chart

Actually the initContainer.securityContext value set all the securityContext for all containers except the 'wait-for-db' one. This PR simply set the securityContext to the 'wait-for-db' initContainer the same way than the other initContainers.

It may be considered as a breaking change as it can break the wait-for-db initContainer depending on what people specified in the initContainer.securityContext already.

If you prefer, I can also add a new value in values.yaml file to set the wait-for-db securityContext (something like waitForDb.securityContext). IMO normalization is always better. But the decision is yours.

rjkernick commented 2 years ago

Please increment the version in chart.yaml and then we can get this merged in

lepouletsuisse commented 2 years ago

Please increment the version in chart.yaml and then we can get this merged in

Done