search

Oteemo / charts

Helm chart repository
https://oteemo.github.io/charts
MIT License
181 stars 232 forks source link

service account name only used if serviceAccount.create = true #327

Closed michbeck100 closed 2 years ago

michbeck100 commented 2 years ago

Given this values.yaml:

serviceAccount:
  create: false
  name: my-custom-account

The deployment is still using the release name, because the name is only used if serviceAccount.create is true: https://github.com/Oteemo/charts/blob/master/charts/sonarqube/templates/deployment.yaml#L48

michbeck100 commented 2 years ago

Nevermind, i will use the new official helm chart from https://github.com/SonarSource/helm-chart-sonarqube. They fixed this issue apparently: https://github.com/SonarSource/helm-chart-sonarqube/commit/640709993c1fad6f73691953d66626adf2de5d53