search

OtherCrashOverride / go-play

Retro emulation for the ODROID-GO
https://www.hardkernel.com/shop/odroid-go/
218 stars 72 forks source link

[NES] Display alignment #13

Closed puggile closed 6 years ago

puggile commented 6 years ago

Hi, I've noticed that nes emulator has not perfect alignment in the display. You can see easily in game like Castlevania where on the top-left on the screen there are player stats truncated. Like the last pixel line is cut. If i play in scaling mode the game is perfect.

firmware version: 20180702-psram

OtherCrashOverride commented 6 years ago

When full screen, 4 pixels are removed from each side of the display: https://github.com/OtherCrashOverride/go-play/blob/eb05c0a1faf67728bb65166953d80ffc470b6d80/odroid-go-common/components/odroid/odroid_display.c#L1047

This was done for performance reasons as scaling is done on the CPU.

[edit] On a real TV, the pixels are in the overscan region typically not displayed.

puggile commented 6 years ago

thanks for explanation!