search

OtherCrashOverride / go-play

Retro emulation for the ODROID-GO
https://www.hardkernel.com/shop/odroid-go/
218 stars 72 forks source link

Add additional volume level - Issue #14 #25

Closed kamotswind closed 6 years ago

kamotswind commented 6 years ago

This should be what is needed for the additional volume levels based on what @DavidKnight247 proposed. I also noticed some debug messages had accidental copy/paste errors and corrected them. I also set the default volume to level 1 since I think that would be a good default to start with instead of full blast. If any of this needs changing or splitting in to a different pull request please let me know.

OtherCrashOverride commented 6 years ago

Since the device is self assembled, I would rather something think "its too loud" than "something is wrong". I think LEVEL_3 is a better default.

kamotswind commented 6 years ago

So setting 4 of 5? Or do you prefer max volume as default which would be LEVEL_4 in this patch?

OtherCrashOverride commented 6 years ago

Use LEVEL_3 (the current value) because LEVEL_4 (100%) is now very loud.

kamotswind commented 6 years ago

Got it!

kamotswind commented 6 years ago

I think this is ready.

OtherCrashOverride commented 6 years ago

"Squash" it so all the commits except the typo correction are a single commit. The end result is there should be two (2) commits: one for the typos, and one for the feature.

DavidKnight247 commented 6 years ago

Lovely, I’ll tweak the volume settings when your commit is merged.

kamotswind commented 6 years ago

Well after some unrelated distractions and a little fighting with git, this is now ready.