search

OtherCrashOverride / go-play

Retro emulation for the ODROID-GO
https://www.hardkernel.com/shop/odroid-go/
218 stars 72 forks source link

8 bit sound #35

Closed DavidKnight247 closed 6 years ago

DavidKnight247 commented 6 years ago

The spectrum emulator generates an 8 bit mono audio buffer. Should I change this to 16 bits stereo in order to use the current odroid_common audio processing or should odroid_common be able to accept 8 and 16 bit & mono and stereo?

OtherCrashOverride commented 6 years ago

The sound has to be 16bit since the esp-idf API's will not accept 8bit samples that I am aware of. Its possible this limitation was fixed, but it would require testing.

DavidKnight247 commented 6 years ago

Ok I’ll generate the expected 16bit audio buffer. On Wed, 11 Jul 2018 at 04:38, OtherCrashOverride notifications@github.com wrote:

The sound has to be 16bit since the esp-idf API's will not accept 8bit samples that I am aware of. Its possible this limitation was fixed, but it would require testing.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OtherCrashOverride/go-play/issues/35#issuecomment-404034879, or mute the thread https://github.com/notifications/unsubscribe-auth/AHxQsbO2hb0wlA1cFROiXJyHiYz1U7caks5uFXNEgaJpZM4VKcBH .