search

OtherCrashOverride / go-play

Retro emulation for the ODROID-GO
https://www.hardkernel.com/shop/odroid-go/
218 stars 72 forks source link

Game list locks up in new version when many games are present for the system #59

Closed wvdschel closed 6 years ago

wvdschel commented 6 years ago

I have recently upgrade to the following versions:

On my SD card I have a couple of hundred Game Boy ROMS, and the system locks up when I try to open the list. It worked fine before.

OtherCrashOverride commented 6 years ago

This likely due to the change in file sorting. Previously, the order was numeric: "B" < "a". Now the order is case insensitive: "B" > "a".

I mentioned on the forum:

Since the file list is sorted, it is necessary to load all the file names into memory. After this a 'quick sort' is performed. This algorithm, like all fast sorts, is recursive: it takes more memory depending on how 'unsorted' the list is. Deleting and re-copying games changes this 'natural order' and that is why it affects success. Adding, erasing, or renaming a file will also affect success.

Testing is done with 2,724 NES files, 1,424 GBC files, and 1,609 GB files.

OtherCrashOverride commented 6 years ago

The 20180810 release should address this.

wvdschel commented 6 years ago

Confirmed fixed :+1: