search

Otouto / gulp-raster

gulp task for conversion svg to raster
MIT License
18 stars 16 forks source link

Error occured during file conversion #2

Closed nelsonpecora closed 10 years ago

nelsonpecora commented 10 years ago

I get this error every time I try to use it, no matter what options I pass to it. Also, it doesn't look like this plugin has any tests.

[gulp] Starting 'icons'...
Tue, 29 Apr 2014 19:48:22 GMT uncaughtException: Error occured during file conversion
Error: Error occured during file conversion
  at /Applications/MAMP/htdocs/bolster-mvp/node_modules/gulp-raster/index.js:23:34
  at /Applications/MAMP/htdocs/bolster-mvp/node_modules/gulp-raster/lib/index.js:22:24
  at ChildProcess.exithandler (child_process.js:635:7)
  at ChildProcess.EventEmitter.emit (events.js:98:17)
  at maybeClose (child_process.js:735:16)
  at Socket.<anonymous> (child_process.js:948:11)
  at Socket.EventEmitter.emit (events.js:95:17)
  at Pipe.close (net.js:466:12)
nelsonpecora commented 10 years ago

Ahah. Figured it out. phantomjs seems to be breaking when it tries to load svgs with hashmarks in their names. Removing them fixed it, but you might want to note that in the readme (since a lot of people are coming to this from grunticon, which has a naming scheme that involves hashmarks).

Otouto commented 10 years ago

Hi, thanks for catching this. Can you provide "wrong" file name for example?

nelsonpecora commented 10 years ago

Looks like anything with hashmarks, which makes sense since I imagine they're being parsed as urls by phantomJS.

cog.colors-#3b3b3b.svg
facebook.colors-#fff-#666.svg

See this doc for grunticon's color spec. It's a bit weird.

Otouto commented 10 years ago

@yoshokatana seems it was fixed in 26b0b045806ce7bd259265b46b88a6f191cf44d9 please, verify

nelsonpecora commented 10 years ago

Yep, looks like it works. Sweet!