search

OttPeterR / addon-babybuddy

BabyBuddy, wrapped into a Home Assistant addon
35 stars 13 forks source link

feat: fix ingress configuration #27

Closed talltechdude closed 1 year ago

talltechdude commented 1 year ago

Hopefully getting #2 resolved by adding some custom nginx entries to rewrite resource paths with the ingress prefix provided in HTTP headers.

Additionally, optional support for automatic auth via ingress to skip login prompt by specifying login username in addon configuration.

The subpath option discussed in #2 seemed to affect both the direct port forward as well in my testing and would have required a breaking change for all exisiting users, so this should allow both ingress and port forwards to co-exist where desired.

OttPeterR commented 1 year ago

This is exciting! I'll review it later this evening. Thanks in advance for taking the time, this feature will make a lot of people happy 👍

jampez77 commented 1 year ago

this feature will make a lot of people happy 👍

Never a truer word spoken! I can't wait for this as we have another child due in May.

OttPeterR commented 1 year ago

checked it over and it all looks good to me, huge thanks for doing this!