search

OtterBrowser / otter-browser

Otter Browser aims to recreate the best aspects of the classic Opera (12.x) UI using Qt5
https://otter-browser.org
GNU General Public License v3.0
1.82k stars 278 forks source link

Toolbar border displayed incorrectly #1310

Open pierreporte opened 7 years ago

pierreporte commented 7 years ago

Appeared with dda5d5cb77787e43dd9d45aceb686004d7c664aa.

With widget pages, there is a double border:

s lection_560

With normal pages, the extra border disappears but the margin between the two borders doesn’t:

s lection_561

Emdek commented 7 years ago

Can't I push work in progress anymore? :-P Plus that looks like some style bug with broken default layouts, they should have no margins.

pierreporte commented 7 years ago

I can’t test a lot of styles for now, especially Adwaita. Fusion is shown on my screenshots. With clearlooks and Windows styles, there is no border with web pages:

s lection_563

s lection_562

The next AppImage that includes this commit will enable me to test with Adwaita style.

Emdek commented 7 years ago

@pierreporte, my Fusion works just fine (with webpages, I'm still not sure if extra line in case of special pages can be even considered an issue, it's just a change). Are you using any stylesheets for widgets?

BTW, it's a good idea to ask about such stuff on IRC first, that would really improve workflow. :-P

pierreporte commented 7 years ago

@Emdek No I don’t use any custom stylesheets.

Next time, I’ll try to think about IRC first.

pierreporte commented 7 years ago

I just tested the weekly 167 AppImage that uses the Adwaita theme. The border is absent with web pages.

Emdek commented 7 years ago

@pierreporte, the only sensible solution seems to be forcing it everywhere except macOS style (since they do it right). Fusion is very close but for some reason doesn't draw line for Status Bar.

pierreporte commented 7 years ago

If you are going to force thing for themes, maybe it’s a sign that it it time to have a full custom theme like any other browser. Then we would control everything on every platform. By the way, it would allow issues #36, #116, (at least a part of) #190, #847, #1010, and several others to be closed.

Emdek commented 7 years ago

@pierreporte, even if there will be some fully custom style I still don't want to force it, one of the original goals of this project was to provide as good integration with system as possible, but under X11 it is harder since there are simply too many completely different styles... I'm considering a bit different approach, going for separate wrappers with fine some minor tuning for styles like Fusion (since it is ALWAYS available), Oxygen and Breeze (these don't suffer much from these borders but maybe they could be improved slightly), Ambiance (it already has own code path in FreeDesktopOrgPlatformStyle, and Unity will be relevant in years to come, but Canonical failed to prepare Qt style counterpart, which is trivial when you just want to get these blackish backgrounds...) and maybe one or two popular GTK themes. Others will have to fallback to current approach (used everywhere except of default style under macOS) or need support from third parties.