search

OtterBrowser / otter-browser

Otter Browser aims to recreate the best aspects of the classic Opera (12.x) UI using Qt5
https://otter-browser.org
GNU General Public License v3.0
1.83k stars 277 forks source link

Bookmarks manager: Visits counter not incremented properly #1542

Open beastie1 opened 6 years ago

beastie1 commented 6 years ago

The Visits counter in a bookmark's Properties is not incremented properly. It seems that every time a bookmark is loaded, the counter is increased by 3 instead of 1.

aurhat commented 6 years ago

It works correct in my RC 12/current master branch, maybe it happens only on some specific websites? Could you give an example of such website?

beastie1 commented 6 years ago

Thanks @aurhat and sorry for the belated reply. It seems to occur randomly: many bookmarks have that problems while others don't. Maybe it's related to how old these are (when they were added) or it has something to do with the bookmark file itself. The file (and profile) is quite old so I'm not sure all the automatic migrations went through properly. I'll have to do further testing with the bookmark file and profile when I have some free time.

beastie1 commented 6 years ago

Another issue that may be related is that the Visits are not incremented when there's any kind of redirection.

Say for example the bookmark was initially saved with the http protocol but the server now redirects to https (http://domain.com vs https://domain.com) or it was saved with (or without) the www subdomain (domain.com vs www.domain.com).

The only way to solve this is by editing the bookmarks to reflect the changes.

beastie1 commented 6 years ago

So I finally got the time to test this out. The first issue is caused by History/RememberBrowsing=false.

Can you reproduce the bug on your setup?

aurhat commented 6 years ago

Yes, nice :+1: