search

OtterBrowser / otter-browser

Otter Browser aims to recreate the best aspects of the classic Opera (12.x) UI using Qt5
https://otter-browser.org
GNU General Public License v3.0
1.83k stars 277 forks source link

Folder bookmark can be added as Home Page #1627

Open fnkkio opened 4 years ago

fnkkio commented 4 years ago

Steps to reproduce:

  1. Go to Tools > Preferences > General
  2. Under Home Page select Use Bookmark
  3. Select This Folder to set a bookmark folder as Home Page

Actual: Bookmark selection menu allows selection of folders.

Expected: In this case, bookmark selection menu should not allows selection of folders; it doesn't make sense to have a bookmark folder as home page.

Video demo: https://youtu.be/pc4Unu7_uvk

Emdek commented 4 years ago

@fnkkio, I'm wondering if this is an issue in the first place, as long as it works properly and opens all links from the folder... If it works "properly" then perhaps warning could be sufficient.

Frenzie commented 4 years ago

I agree, it's only an issue of sorts if nothing happens.

fnkkio commented 4 years ago

@Emdek @Frenzie It does not open all webpages, it opens a webpage with the url: bookmarks:x (where x can be 0 / 1 / ...). I should have been more specific in the description.

Also, in my opinion, even if it opened all webpages in the folder, it wouldn't make much sense since we have session for that.

Frenzie commented 4 years ago

But what does that webpage show? Does it display the folder?

fnkkio commented 4 years ago

@Frenzie It does not display anything.

fnkkio commented 4 years ago

Added video demo in first comment.

Frenzie commented 4 years ago

In the meantime I've reached a computer. ;-)

I think the correct behavior would be something more like this (as a separate tab):

Screenshot_2019-12-04_21-31-41

Or perhaps rather like this:

Screenshot_2019-12-04_21-32-20

Disallowing folder selection is of course an easy way out.

fnkkio commented 4 years ago

@Emdek @Frenzie

Verified this issue again: This only happens when the bookmark folder is no longer available; if the bookmark is available, it will ask to open all bookmark URLs in folder. (As a side-note this happened to me because I was importing bookmark and because of an issue, bookmarks were not stored between application restarts).

If this is ok / the expected behaviour, then we can close this issue.

Frenzie commented 4 years ago

I'd say it should display a little error message about folder not found then. Sounds like the functionality is good. ;-)