OtterBrowser / otter-browser

Otter Browser aims to recreate the best aspects of the classic Opera (12.x) UI using Qt5
https://otter-browser.org
GNU General Public License v3.0
1.8k stars 277 forks source link

Toolbar options not saved #1642

Open ghost opened 4 years ago

ghost commented 4 years ago

describe the steps required to reproduce issue Open otter browser Set any bar enabled by default (e.g. menu bar, or locking the bar) to not shown Close the browser Reopen the browser Excepted behaviour: disabled bars are still disabled Behaviour experienced: bar settings are reset (menu, status, etc. shown, bars unlocked) attach a backtrace if you have any No crash report. If you need any logs, I will provide them post details about your setup: application version (for example, 1.0.01 32 bit), from about otter: Otter 1.0.01 Web browser controlled by the user, not vice-versa. https://www.otter-browser.org/

Web backend: Blink Backend (experimental) 77.0.3865.129.

SSL library version: BoringSSL system version (for example, Ubuntu 18.04 64 bit) Artix linux (kernel 5.6.4, rolling release distro based on arch) Init system: runit DE: Cinnamon Both otter and qt were installed as binaries, compiled by the artix team. Qt version (for example, Qt 5.6.0 MSVC 64 bit). from about qt in otter: About Qt This program uses Qt version 5.14.2.

ghost commented 4 years ago

Update: Here is the contents of ~/.config/otter/toolBars.json ''' [ { "actions": [ "PrivateWindowIndicatorWidget", "TabBarWidget", "spacer", "NewTabAction", "BookmarkPageAction", "TransfersWidget", "ClosedWindowsMenu", "ContentBlockingAction", "MenuButtonWidget" ], "buttonStyle": "iconOnly", "fullScreenVisibility": "hover", "identifier": "TabBar", "location": "top", "normalVisibility": "visible", "row": 0, "title": "Tab Bar" }, { "actions": [ "GoBackAction", "GoForwardAction", "ReloadOrStopAction", "AddressWidget" ], "buttonStyle": "iconOnly", "fullScreenVisibility": "hidden", "identifier": "AddressBar", "normalVisibility": "visible", "row": 0, "title": "Address Bar" } ] ''' Please note, there was a bookmarks toolbar item in this json, and I removed it. Now the bookmarks toolbar does not appear when I start otter. Editing otter.conf manually, I saw that lock panels was set to true, but it didn't lock panels for some reason on bootup until I actually edited and closed otter.conf. Now panels are locked. Statusbar still reappears, even though I disabled it inside the UI.

ghost commented 4 years ago

Second update: I checked how the default.json session file changes. When I open otter, and disable the menu bar, it is changed in the file. When I close otter, it is still disabled. Upon reopening otter, the menu bar is re-enabled.

Emdek commented 4 years ago

@Productive2, which session mode are you using (continue previous or something else)?

ghost commented 4 years ago

where to check this exactly?