OtterBrowser / otter-browser

Otter Browser aims to recreate the best aspects of the classic Opera (12.x) UI using Qt5
https://otter-browser.org
GNU General Public License v3.0
1.8k stars 277 forks source link

[Windows] DDE or shell open bug includes fix #1646

Open stahta01 opened 4 years ago

stahta01 commented 4 years ago

My development setup: application version: 1.0.81-dev 64 bit git commit 22fe4702210119fc806b2a9508d05c5a6a3f216c system version: MSys2 MinGW 64 bit under Win7 64 bit Qt version: Qt 5.14.2 MSys2 MinGW 64 bit webkit: 602.1

Problem: Message box pops up with this message "There was a problem sending the command to the program." Note: The html file is opened in the browser okay.

Step 1: Register file extensions Tools -> Preferences Click on button "Set as a default browser" The next two steps are not needed for My development setup Checkmark the file extensions Click on save

Step 2: Right click on an html file and select open

001-Windows-comment-out-ddeexec.zip

Attached zipped patch file that seems to fix the issue.

The only change in the patch is to comment out the next line in WindowsPlatformIntegration.cpp m_propertiesRegistration.setValue(QLatin1String("shell/open/ddeexec/."), {});

Edit: I had to delete the bad registry entry during testing. `[HKEY_CLASSES_ROOT\OtterBrowser\shell\open\ddeexec]

@="@Invalid()" `

Tim S.

Emdek commented 4 years ago

@bajasoft, do you remember why this line was needed in the first place?