[Regression]: toolbars not being shown, missing text in View/Toolbars menu

[RJVB]

I just upgraded to the current git HEAD and am seeing a very annoying regression:

This is a clean start, i.e. after moving aside my ~/.config/otter directory. Poking around a little bit I even managed to get into a state where neither menu nor toolbars were shown, and I had to edit the session json file in otter/sessions to get them back. Well, the menubar at least...

This is on Linux, using Qt 5.9.8, QtWebKit 5.212.alpha4 and en_GB as my system locale but I'm seeing the same issue with the same Qt versions on Mac OS X.

[RJVB]

I can confirm it also happens with Qt 5.12 .

Another possibly relevant observation: I'm building with clang and LTO (-flto=thin); the down-to-earth explanation of empty menus would be that the item title strings are optimised away by the optimiser because of

    Q_UNUSED(QT_TRANSLATE_NOOP("actions", "Menu Bar"))

(etc) in the ToolbarsManager ctor. I'm currently reverting #4ae5f471 and #cc55d00f to see if these introduced the regression.

[RJVB]

Reverting both (or only #cc55d00f) indeed fixes the issue; LTO isn't the culprit.

[domr2695]

I have in the latest versions of browser also lost the line of open bookmarks and the address bar. Then I closed the browser, deleted "toolBars.json" from~/. config/otter, and copied it from the source folder of the latest version (3579460 from 2020-06-20) ./resources/otter/toolBars.json. I started the browser — the line of open bookmarks and the address bar reappeared.

[RJVB]

I think you were lucky (or there have been improvements since I last pulled and built the browser. As per my initial report, I also deleted that toolBars.json, with the entire config directory. That is, a "factory reset" - and I would have to assume that the recreated version of the file corresponded to the one from the source tree. I think this operation changed the symptoms a bit but not the issue itself; the real fix was reverting cc55d00f.

[domr2695]

I have Debian 10.4, Qt5 5.12.5+dfsg-10+b1, libqt5webkit5 5.212.0~alpha4-1+b1. In Otter Help - >About (Webkit 602-1, OpenSSL 1.1.1 g, Qt 5.12-5). Downloaded (git clone https://github.com/OtterBrowser/otter-browser) version 3579460 from 2020-06-20 (but better the last one). In addition to dealing with the loss of the row of open tabs and the address bar (as I wrote You before) was a fully imported the bookmarks file in HTML format from Firefox size to 32 Mb, and before it had divided into 4 parts to load separately and then combine into one folder (itself Firefox it exported fine before, but to import it began only recently and it is very long and with different warnings). Finally, Otter stopped randomly hanging dead when viewing the site "https://zen.yandex.ru" (which for more than six months got me with terrible force and had to complete it and start again). Stacks of videos began to be viewed normally (as in https://yandex.ru/news/story/Dlya_vakcinacii_rossiyan_ot_koronavirusa_potrebuetsya_do_70_millionov_doz--920b245610509e5b60e68692f108fab7?from=main_portal&lang=ru&lr=213&mlid=1592808784.glob_225.920b2456&msid=1592809548.58183.82837.97225&persistent_id=103136081&stid=DwbtxH9F1sULlYEspZLD&t=1592808784&utm_medium=topnews_news&utm_source=morda_desktop&wan=1) and do not hang up Otter (although now with messages that it does not support new video technologies and it needs to be updated). So all of a sudden there were so many nice things. I attribute this to the Webkit update to 602-1, but this is only a suspicion, maybe the browser developers are involved in this. I want to note that on the one hand, browser developers are asked to report problems, and on the other hand they do not respond to them in any way. This is confirmed by their lack of reaction to my message "https://github.com/OtterBrowser/otter-browser/issues/1639" and every time you update the browser source code, you need to edit it in two places and rebuild it (and so on for more than six months).

[RJVB]

On Monday June 22 2020 00:39:56 domr2695 wrote:

... In addition to dealing with the loss of the row of open tabs and the address bar (as I wrote You before)

Not for me, I still need to revert cc55d00f9ed8898aa778ce7572e28a48b298554d, and, annoyingly, I still need to suppress the toolbars section from the session json file in ~/.config/otter/sessions because it is empty after testing WITHOUT the revert.

[Emdek]

@RJVB, I didn't have time to research it properly yet, but it's likely that one of mappers is misconfigured.

[RJVB]

No hurries as far as I'm concerned, as long as the revert patch for the "incriminated" commit applies cleanly ;)

[Emdek]

@RJVB, no need to revert anything. ;-) Do you still have any issues with above change?

[RJVB]

No, indeed, no longer need to revert that 1 particular commit.

Any idea what was wrong, and how the non-showing of toolbars was related to empty items in the Toolbar view menu?