OtterBrowser / otter-browser

Otter Browser aims to recreate the best aspects of the classic Opera (12.x) UI using Qt5
https://otter-browser.org
GNU General Public License v3.0
1.79k stars 272 forks source link

Compilation error #1737

Closed TCH68k closed 1 year ago

TCH68k commented 1 year ago

I have a script which automatically updates my local Otter repo and then compile and install the binary. It worked for years, but now it stopped working: it cannot compile src/ui/ItemViewWidget.cpp:

/opt/otter/src/ui/ItemViewWidget.cpp:998:27: error: no member named 'placeholderText' in 'QPalette'
        painter.setPen(palette().placeholderText().color());
                       ~~~~~~~~~ ^
[ 56%] Building CXX object CMakeFiles/otter-browser.dir/src/ui/MenuBarWidget.cpp.o
1 error generated.
CMakeFiles/otter-browser.dir/build.make:1683: recipe for target 'CMakeFiles/otter-browser.dir/src/ui/ItemViewWidget.cpp.o' failed
make[2]: *** [CMakeFiles/otter-browser.dir/src/ui/ItemViewWidget.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
CMakeFiles/Makefile2:95: recipe for target 'CMakeFiles/otter-browser.dir/all' failed
make[1]: *** [CMakeFiles/otter-browser.dir/all] Error 2
Makefile:170: recipe for target 'all' failed
make: *** [all] Error 2

Debian 9, CLang 12 (but did the same with GCC 7) and Qt 5.10.

Emdek commented 1 year ago

@TCH68k, it turns out that QPalette::placeholderText() is Qt 5.12 addition, I'll deal with it.

TCH68k commented 1 year ago

Thanks, it worked.