OtterBrowser / otter-browser

Otter Browser aims to recreate the best aspects of the classic Opera (12.x) UI using Qt5
https://otter-browser.org
GNU General Public License v3.0
1.81k stars 277 forks source link

Improve storage of favicons #820

Open Emdek opened 9 years ago

Emdek commented 9 years ago

Reliability of favicons storage (as part of global history) needs improvements.

VSHY commented 9 years ago

That global storage of favicons would be better to use for searches also. Now the favicons are stored in \searches*.xml-files.

Emdek commented 9 years ago

@VSHY, nah, they use embedded icons for a reason, it's part of the standard (it's customizable using built-in editor) and won't randomly change if service will choose to change own icon (like Google did multiple times in the past).

VSHY commented 9 years ago

@Emdek, In my some Opera skin was the old icon. Time passed and I changed it to a new, because it did not correspond icon which located into the address bar, history, etc. Therefore, a static icon - not a good idea. It has two different logic, and each has a right to exist.

Emdek commented 9 years ago

@VSHY, this is why that standard allows to embed link to original resource so it can be updated from time to time. ;-)

beastie1 commented 9 years ago

I wish favicons were displayed even when images are disabled globally.

Emdek commented 9 years ago

@beastie1, uhm, are they affected by that setting? If yes then it would be another reason to use custom algorithm to fetch them in QtWebKit backend (QtWebEngine needs that anyway)...

VSHY commented 9 years ago

@Emdek Will you add the button for updating of the icon in the certain search later? :)

Emdek commented 9 years ago

@VSHY, currently it can be set manually using search engine editor, that should be good enough in most cases.

VSHY commented 9 years ago

I found it) Thanks.

cofi89 commented 7 years ago

Hi @Emdek, Any status/plans/ETA on this?

Emdek commented 7 years ago

@cofi89, sure, I forgot to readd milestone. There are some initial designs but nothing solid yet.