Ottermandias / GatherBuddy

Dalamud-based FFXIV addon to simplify gathering.
Apache License 2.0
93 stars 89 forks source link

Fixed certain fishes not being marked as having uptime dependency #204

Closed MTVirux closed 9 months ago

MTVirux commented 9 months ago

Addresses #203 Fixed certain fishes not being marked as having uptime dependency

This was done by adding a check to see if the Goal Fish has a weather requirement at all, instead of just checking it against the mooch weather requirements.

Ottermandias commented 9 months ago

Aren't the checks just the wrong way anyway? We're checking if fs requirements are contained in fishs requirements, so if the intersection of both of them is contained in fish, fish has more or equal restrictions to f. But we want to check for fish having fewer restrictions than f, so we need to check if the intersection against f, not `fish.