search

Ottermandias / GatherBuddy

Dalamud-based FFXIV addon to simplify gathering.
Apache License 2.0
94 stars 95 forks source link

gatherbuddy crash, lag spikes when not crashing #24

Closed sleepylinde closed 3 years ago

sleepylinde commented 3 years ago

Hello,

after the recent update I noticed GatherBuddy started to lag when I try to mouseover fish. Doing so also crashes the game sometimes, although I don't see anything in the dalamud log. After the most recent crash I logged into the game again and GatherBuddy threw another error. I love your plugin and hope this can be fixed!

Error log from starting the game after the crash: 

2021-10-11 13:19:32.899 +02:00 [ERR] [GatherBuddy] UiBuilder OnBuildUi caught exception
System.NullReferenceException: Object reference not set to an instance of an object.
   at GatherBuddy.SeFunctions.EventFramework.get_FishingState() in H:\Projects\FFPlugins\GatherBuddy\SeFunctions\EventFramework.cs:line 28
   at GatherBuddy.Gui.FishingTimer.Draw() in H:\Projects\FFPlugins\GatherBuddy\Gui\FishingTimer.cs:line 351
   at Dalamud.Interface.UiBuilder.OnDraw() in C:\goatsoft\companysecrets\dalamud\Interface\UiBuilder.cs:line 287
2021-10-11 13:19:32.922 +02:00 [INF] LASTEXCEPTION:eyJXaGVuIjoiMjAyMS0xMC0xMVQxMzoxOTozMi45MjE5NDMrMDI6MDAiLCJJbmZvIjoiU3lzdGVtLk51bGxSZWZlcmVuY2VFeGNlcHRpb246IE9iamVjdCByZWZlcmVuY2Ugbm90IHNldCB0byBhbiBpbnN0YW5jZSBvZiBhbiBvYmplY3QuXHJcbiAgIGF0IEdhdGhlckJ1ZGR5LlNlRnVuY3Rpb25zLkV2ZW50RnJhbWV3b3JrLmdldF9GaXNoaW5nU3RhdGUoKSBpbiBIOlxcUHJvamVjdHNcXEZGUGx1Z2luc1xcR2F0aGVyQnVkZHlcXFNlRnVuY3Rpb25zXFxFdmVudEZyYW1ld29yay5jczpsaW5lIDI4XHJcbiAgIGF0IEdhdGhlckJ1ZGR5Lkd1aS5GaXNoaW5nVGltZXIuRHJhdygpIGluIEg6XFxQcm9qZWN0c1xcRkZQbHVnaW5zXFxHYXRoZXJCdWRkeVxcR3VpXFxGaXNoaW5nVGltZXIuY3M6bGluZSAzNTFcclxuICAgYXQgRGFsYW11ZC5JbnRlcmZhY2UuVWlCdWlsZGVyLk9uRHJhdygpIGluIEM6XFxnb2F0c29mdFxcY29tcGFueXNlY3JldHNcXGRhbGFtdWRcXEludGVyZmFjZVxcVWlCdWlsZGVyLmNzOmxpbmUgMjg3IiwiQ29udGV4dCI6IltcIkdhdGhlckJ1ZGR5XCJdIFVpQnVpbGRlciBPbkJ1aWxkVWkgY2F1Z2h0IGV4Y2VwdGlvblxuU3lzdGVtLk51bGxSZWZlcmVuY2VFeGNlcHRpb246IE9iamVjdCByZWZlcmVuY2Ugbm90IHNldCB0byBhbiBpbnN0YW5jZSBvZiBhbiBvYmplY3QuXHJcbiAgIGF0IEdhdGhlckJ1ZGR5LlNlRnVuY3Rpb25zLkV2ZW50RnJhbWV3b3JrLmdldF9GaXNoaW5nU3RhdGUoKSBpbiBIOlxcUHJvamVjdHNcXEZGUGx1Z2luc1xcR2F0aGVyQnVkZHlcXFNlRnVuY3Rpb25zXFxFdmVudEZyYW1ld29yay5jczpsaW5lIDI4XHJcbiAgIGF0IEdhdGhlckJ1ZGR5Lkd1aS5GaXNoaW5nVGltZXIuRHJhdygpIGluIEg6XFxQcm9qZWN0c1xcRkZQbHVnaW5zXFxHYXRoZXJCdWRkeVxcR3VpXFxGaXNoaW5nVGltZXIuY3M6bGluZSAzNTFcclxuICAgYXQgRGFsYW11ZC5JbnRlcmZhY2UuVWlCdWlsZGVyLk9uRHJhdygpIGluIEM6XFxnb2F0c29mdFxcY29tcGFueXNlY3JldHNcXGRhbGFtdWRcXEludGVyZmFjZVxcVWlCdWlsZGVyLmNzOmxpbmUgMjg3In0=

I'm also confused about the path (H:\Projects\FFPlugins\GatherBuddy\SeFunctions\EventFramework.cs:line 28) since I do not have a drive mounted to H.

Ottermandias commented 3 years ago

The path is from where it was compiled (i.e. my PC), not yours. Mouseover what fish? Ingame tooltips or in the Timed Fish window or in the timer? Where you fishing then? Can I get a full log?

sleepylinde commented 3 years ago

Thanks for the clarification. I recorded the steps I did which either lead to frame drops or crashing here: https://youtu.be/K4X3lWwfnBk

The only input at that time was me moving my mouse and also the mouse wheel at the same time near the end.

Here's the full log: dalamud.log

Ottermandias commented 3 years ago

Neither me nor multiple other people can reproduce those issues at the moment. What OS are you on and do you use TexTools? Otherwise I have no idea what might be causing this.

You might want to try disabling all plugins except for GatherBuddy and see if it happens then - though from your plugin list I wouldn't know why any of those would conflict.

sleepylinde commented 3 years ago

It's the latest win10 build. I dont use TexTools however cmtools and Anamnesis are installed but currently not running. The only thing I haven't mentioned is that the fflogs companion app (the overwolf thing) is also running.

image

Edit: I'll go and try what you suggested by disabling all except GB.

sleepylinde commented 3 years ago

Ok, just gonna list my steps here:

1) removed Overwolf and fflogs companion app -> still crash 2) "turned off" gshade by selecting the off.ini -> still crash 3) removed all plugins except gatherbuffy and outdated fanyloadingscreens -> still crash 4) removed the fancyloadingscreen plugin -> now it's working as intended.

For whatever reason the loadingscreen plugin managed to interact with GB and cause these lags and crashes. Now I have everything activated again (the whole plugin list from the video without fancyloading screens, gshade but no overwolf anymore) and GB is working as intended.

Ottermandias commented 3 years ago

Well, I don't understand that at all, but good job fixing it! :D