search

OttoAllmendinger / gnome-shell-screenshot

Gnome Shell extension for making and uploading screenshots
MIT License
266 stars 53 forks source link

GNOME 3.36 support #110

Closed ai closed 4 years ago

ai commented 4 years ago

When I try to install the extension on GNOME 3.35 I got Error in the install button.

Unfortunately, I didn’t find anything related to your extension in the system log. I can provide some extra details if you say me where to find them.

fabiscafe commented 4 years ago

This is what I got:

journalctl -b | grep "gnome-shell-ext"
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/version.js 31]: reference to undefined property 0
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/prefs.js 121]: Too many arguments to method Gtk.Container.add: expected 1, got 2
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/prefs.js 130]: Too many arguments to method Gtk.Container.add: expected 1, got 2
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/prefs.js 160]: Too many arguments to method Gtk.Container.add: expected 1, got 2
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/prefs.js 193]: Too many arguments to method Gtk.Container.add: expected 1, got 2
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/prefs.js 214]: Too many arguments to method Gtk.Container.add: expected 1, got 2
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/prefs.js 258]: Too many arguments to method Gtk.Container.add: expected 1, got 2
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/prefs.js 288]: Too many arguments to method Gtk.Container.add: expected 1, got 2
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/prefs.js 356]: Too many arguments to method Gtk.Container.add: expected 1, got 2
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/prefs.js 364]: Too many arguments to method Gtk.Container.add: expected 1, got 2
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/prefs.js 388]: Too many arguments to method Gtk.Container.add: expected 1, got 2
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/prefs.js 403]: Too many arguments to method Gtk.Container.add: expected 1, got 2
Mar 08 15:35:56 balder gnome-shell-ext[14243]: JS WARNING: [/home/fabi/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/prefs.js 417]: Too many arguments to method Gtk.Container.add: expected 1, got 2

In looking glas ( @ai [ALT]+[F2] -> lg -> [ENTER]) the error is: Error: Argument 'display' (type interface) may not be null

ai commented 4 years ago

@OttoAllmendinger is it enough to fix 3.36 support?

3.36 will be released tomorrow (March 9)

OttoAllmendinger commented 4 years ago

I'm still looking for a virtual machine image that has 3.36. Any suggestions?

RaphaelRochet commented 4 years ago

Arch has 3.36 in stable already.

OttoAllmendinger commented 4 years ago

well that's convenient!

OttoAllmendinger commented 4 years ago

fix will be out tomorrow

OttoAllmendinger commented 4 years ago

Support for 3.36 is here: https://github.com/OttoAllmendinger/gnome-shell-screenshot/tree/support-336

That version however drops support for all older gnome-shell versions. Working on support for broader range.

terencode commented 4 years ago

It's working after including 6b37b052ab6ac452739600c880442e5f515f3881 from master on top of support-336 but there is still the following: 

 JS WARNING: [/usr/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/indicator.js 61]: Too many arguments to method Clutter.Container.add_actor: expected 1, got 2
OttoAllmendinger commented 4 years ago

@terencode I saw that too but I don't think it actually causes any problems at the moment

terencode commented 4 years ago

@OttoAllmendinger yeah, just thought I'd mention it.

OttoAllmendinger commented 4 years ago

Support is now in master branch