search

OttoAllmendinger / gnome-shell-screenshot

Gnome Shell extension for making and uploading screenshots
MIT License
267 stars 53 forks source link

pop up/notification when screenshot doesn't appear #115

Closed x0rld closed 4 years ago

x0rld commented 4 years ago

hi i'm on fedora 31 and I don't have the pop up or notification i don't really know what is it the window who ask me about saving/uploading/copy the image

GNOME Shell 3.34.5 and i have no log about this extension when i do journalctl -b /usr/bin/gnome-shell

OttoAllmendinger commented 4 years ago

thanks for the report, I could reproduce the problem and found this stack tracke

Apr 12 10:15:50 localhost.localdomain gnome-shell[9970]: JS ERROR: Exception in callback for signal: notification-added: TypeError: text.replace is not a function
                                                         setTitle@resource:///org/gnome/shell/ui/messageList.js:373:39
                                                         Message@resource:///org/gnome/shell/ui/messageList.js:326:9
                                                         NotificationMessage@resource:///org/gnome/shell/ui/calendar.js:710:9
                                                         _onNotificationAdded@resource:///org/gnome/shell/ui/calendar.js:954:23
                                                         _emit@resource:///org/gnome/gjs/modules/signals.js:135:27
                                                         pushNotification@resource:///org/gnome/shell/ui/messageTray.js:786:9
                                                         notify@resource:///org/gnome/shell/ui/messageTray.js:793:9
                                                         showNotificationCompat@/home/vagrant/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/notifications.js:58:12
                                                         notifyScreenshot@/home/vagrant/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/notifications.js:206:3
                                                         _onScreenshot@/home/vagrant/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/extension.js:292:7
                                                         _emit@resource:///org/gnome/gjs/modules/signals.js:135:27
                                                         emitScreenshotOnSuccess/<@/home/vagrant/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/selection.js:191:5
                                                         callHelper/<@/home/vagrant/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/selection.js:89:5
Apr 12 10:15:50 localhost.localdomain gnome-shell[9970]: JS ERROR: Exception in callback for signal: notify: TypeError: text.replace is not a function
                                                         setTitle@resource:///org/gnome/shell/ui/messageList.js:373:39
                                                         Message@resource:///org/gnome/shell/ui/messageList.js:326:9
                                                         NotificationMessage@resource:///org/gnome/shell/ui/calendar.js:710:9
                                                         NotificationBanner@resource:///org/gnome/shell/ui/messageTray.js:488:9
                                                         createBanner@resource:///org/gnome/shell/ui/messageTray.js:749:16
                                                         createBanner@resource:///org/gnome/shell/ui/messageTray.js:470:16
                                                         createBanner@/home/vagrant/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/notifications.js:91:15
                                                         _showNotification@resource:///org/gnome/shell/ui/messageTray.js:1271:24
                                                         _updateState@resource:///org/gnome/shell/ui/messageTray.js:1227:21
                                                         _onNotify@resource:///org/gnome/shell/ui/messageTray.js:1089:9
                                                         _emit@resource:///org/gnome/gjs/modules/signals.js:135:27
                                                         notify@resource:///org/gnome/shell/ui/messageTray.js:796:13
                                                         showNotificationCompat@/home/vagrant/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/notifications.js:58:12
                                                         notifyScreenshot@/home/vagrant/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/notifications.js:206:3
                                                         _onScreenshot@/home/vagrant/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/extension.js:292:7
                                                         _emit@resource:///org/gnome/gjs/modules/signals.js:135:27
                                                         emitScreenshotOnSuccess/<@/home/vagrant/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/selection.js:191:5
                                                         callHelper/<@/home/vagrant/.local/share/gnome-shell/extensions/gnome-shell-screenshot@ttll.de/selection.js:89:5
x0rld commented 4 years ago

now i see the same things in logs

adueppen commented 4 years ago

I seem to be having the same issue (including similar log entries), and it also ends up meaning that once I take a screenshot, no more notifications will appear at all until I restart the shell.

x0rld commented 4 years ago

oh that's why i don't have like discord and others apps notifications xD

x0rld commented 4 years ago

it's really weird when i am on lockscreen i see some notification about screenshot :thinking: and i can't remove it xD

OttoAllmendinger commented 4 years ago

Yes, gnome 3.34.5 is a bit weird and needs a custom workaround. The fix is a bit tricky. I'll try to get it fixed today.

OttoAllmendinger commented 4 years ago

sorry, took a bit longer than that ;)

master branch should contain the fix

x0rld commented 4 years ago

thx I install from the master it works again