OttoAllmendinger / gnome-shell-screenshot

Gnome Shell extension for making and uploading screenshots
MIT License
268 stars 54 forks source link

Doesn't work with Gnome 41 - even after update to Screenshot Tool v61 #171

Closed speendo closed 2 years ago

speendo commented 2 years ago

So I updated the tool to v61 on my system with Debian Testing installed.

When I select Open Portal I get this grafik

Otherwise, when I try to select one of the other options, I get "Error: Not available for Gnome 41"

The latter one is probably expected behavior, isn't it?

The first one, however really ... reduces ... the usability of the tool.

Please let me know if I can provide any additional information.

lavaicer commented 2 years ago

+1 Me too

oxayotl commented 2 years ago

You need to install the right package. On ArchLinux it was called xdg-desktop-portal . It's still incredibly worse than it was before, but I guess the Gnome gods are fickle mistresses and all that ^^ [edit]To be super clear, it's not, at all, the fault of the devs of this extension, and I appreciate their work a lot! It's because of changes in Gnome for improved security or something[/edit]

speendo commented 2 years ago

hmm, I fear that doesn't solve the problem

grafik

Still doesn't work...

bickkysahani commented 2 years ago

same here it doesnt work in fedora gnome 41 wayland

netroy commented 2 years ago

I'm having the same issue on Gnome 41 on Manjaro. Clearly https://github.com/OttoAllmendinger/gnome-shell-screenshot/issues/158 did not fix everything :sweat_smile: Interestingly if I right click, and "Open Portal", all three modes work just fine from that UI.

but, using either the keyboard shortcut, or clicking on the systray icon gives me this

Error: Not available for Gnome 41

OttoAllmendinger commented 2 years ago

Yes, for now "Open Portal" is the only available option for Gnome 41.

The other capture methods are not available to me any longer.

speendo commented 2 years ago

Thanks for clarifying @OttoAllmendinger. However, on my system "Open Portal" doesn't work either.

prasket commented 2 years ago

Confirmed same error using Debian Bookworm & Gnome 41.1 I get an error when clicking on Open Portal about No such interface... but do have xdg-desktop-portal & gnome-screenshot installed as well.

Right now only way I can take screenshots is to open gnome-screenshot and use it.

MBilderbeek commented 2 years ago

FYI: here on Debian testing (gnome-shell 41.1-1), the open portal options work fine, the others give the error "Not available on gnome 41."

pacho2 commented 2 years ago

If it is impossible to fix it for Gnome 41, I would simply replace the options to simply add a clickable icon in the shell bar to directly open the screenshot dialog. That way it is faster to take the screenshot... even if not so as it was before that we were able to directly choose what kind of screenshot to take and to get it saved automatically to the clipboard :(

I am also unsure if it would be possible to add a preference to choose to run in "unsafe" mode if wanted allowing to use as before

OttoAllmendinger commented 2 years ago

it is possible to open the portal with a single click by setting the "Primary Button" option: image

I am considering these options to restoring the original features:

Sadly I don't have much time to work on this right now.

pacho2 commented 2 years ago

Thanks for the help :)

the only issue is that it seems that portal window gets opened behind the previous windows :/ But maybe it's an issue of the portal

Regarding the use of external tools, why not calling native gnome-screenshot app instead of grim/scrot?

OttoAllmendinger commented 2 years ago

Yes, gnome-screenshot would also be a good option

pacho2 commented 2 years ago
  • Gnome-shell source code has a hardcoded whitelist for programs that are allowed to use the private screenshot API. I could provide instructions on how to add the extension to that list. Then unsafe-mode would not be required.

I think this would be the best option for the short-term :)

Thanks a lot!

OttoAllmendinger commented 2 years ago

New version is pushed to master and pending review in the extension store.

t uses the gnome-screenshot cli tool as the default backend.

Not quite like pre-Gnome40 behavior since the selection highlighting is missing, but much better than the portal option.

pacho2 commented 2 years ago

It works nice

Thanks a lot :D

As a side note, my first tries were silently failing to get the screenshots saved because I had a gnome-screenshot instance opened in a different virtual desktop. I understand it is a really corner case... but I say it for the case someone else hits the same issue some day