search

OttoAllmendinger / gnome-shell-screenshot

Gnome Shell extension for making and uploading screenshots
MIT License
268 stars 54 forks source link

GNOME 45 Support #200

Open craftergarage opened 10 months ago

craftergarage commented 10 months ago

GNOME 45 is in beta now, Please add support for it to ensure compatibility with the latest version of GNOME and provide users with access to new features and improvements.

debianmain1 commented 9 months ago

Really like this & am wondering about the timeline for a 45-capable version?

debianmain1 commented 9 months ago

I just updated to 45 in Arch via extra-testing...it's working flawlessly---just waiting for this extension to complete my extensions.

craftergarage commented 8 months ago

This is good news :)

butterdori commented 8 months ago

Yes, pretty please! This is the best screenshot tool for GNOME.

sagitariozod commented 8 months ago

JS ERROR: Extension gnome-shell-screenshot@ttll.de: SyntaxError: import declarations may only appear at top level of a module @ resource:///org/gnome/shell/misc/extensionUtils.js:4:0

oxayotl commented 8 months ago

I'm working on updating the extension for Gnome Shell 45. As soon as I get it everything to work I'll create a pull request.

oxayotl commented 8 months ago

Okay I think I kinda messed up and edited some generated JS files instead of editing the actual typescript files. I think. I'm not very sure. Anyway you can check it out here and see if it works well: https://choum.net/JA/gnome-shell-screenshot@ttll.de.zip It still has some few issues, for instance I had to add a dot next to the screen capture duration scroller or else it wouldn't show. I'll try to learn typescript and understand how the compilation tools work and make a better update in the future :) .

sagitariozod commented 8 months ago

Thank you very much for the update, it works well, although if I leave the session, without closing it, and come back in, it always shows me the settings screen, it's not a big problem, I close it and that's it. We wait for the next update. Thank you very much for your time.

zrno commented 7 months ago

any news?

OttoAllmendinger commented 7 months ago

Gnome 45 introduced a bunch of breaking changes, a proper upgrade will take a few months

Okay I think I kinda messed up and edited some generated JS files instead of editing the actual typescript files

@oxayotl Thank you, this is still useful for me! I will look into doing a one-time JS release of the extension

oxayotl commented 7 months ago

Great, thanks!!!

Jerther commented 7 months ago

@oxayotl I just tested your version and I'm able to take screenshots! Thank you! :smile:

For those who might need help: 1- Uninstall outdated version 2- unzip oxayotl's version 3- move the unzipped folder into ~/.local/share/gnome-shell/extensions/ 4- Log out, then back in.

jmaargh commented 6 months ago

@oxayotl Any word on that PR? Or do you have a fork with the changes so I can make a PR?

oxayotl commented 6 months ago

@jmaargh I edited the generated javascript instead of the original typescript, so I cannot really make a PR. The files I edited don't exist in the repo. I couldn't figure out how the original typescript files were merged into one and I needed to make changes to that part (the “import” declarations have to be at the top of the file now), so I gave up.

OttoAllmendinger commented 6 months ago

latest commit on master has support for Gnome 45

new version is pending review on e.g.o

happy holidays! :christmas_tree: :santa: