OttoAllmendinger / gnome-shell-screenshot

Gnome Shell extension for making and uploading screenshots
MIT License
268 stars 53 forks source link

Selector sometimes visible in screenshot #28

Open OttoAllmendinger opened 7 years ago

OttoAllmendinger commented 7 years ago

Regression of #16

https://extensions.gnome.org/errors/view/3766 you need to be logged in apparently

Copy of report:

What's wrong?
Timing error causes area screenshots to contain the selector itself sometimes.  This results in a blue tint over screenshots, which can be very inconvenient. 

What have you tried?
I've looked for a way of either hiding the selector or making a delay, but I lack the experience to do so.

Automatically detected errors:

GNOME Shell Extensions did not detect any errors with this extension.

Version information:

    Shell version: 3.22.3
    Extension version: 11
OttoAllmendinger commented 5 years ago

@rvangsgaard thanks, that points towards an upstream problem

@adueppen can you reproduce the tint when setting the delay to 200ms for the extension?

adueppen commented 5 years ago

I just tried it and wasn't able to get the tint to appear at all after setting the delay to 200ms, but I do recall it happening at delays all the way up to 1s not too long ago.

OttoAllmendinger commented 5 years ago

Ok, seems like 200ms seems to be the ballpark number where the the tint effect is less likely to occur. This is the delay that @gitfineon found in the official gnome-screenshot app:

https://gitlab.gnome.org/GNOME/gnome-screenshot/blob/fbc303b2a0ee190958931453111e170db70471fd/src/screenshot-application.c#L579-584

I will just add it as the default lower bound and maybe an option to disable that.

yrdenindeed commented 4 years ago

I noticed I was getting the blue tint in my SHIFT+PRTSCR screenshots on Gnome. I then realized I had used Gnome Tweak Tool to disable animations. Re-enabling animations and my screenshots are fixed, hope this helps.

rvangsgaard commented 4 years ago

I noticed I was getting the blue tint in my SHIFT+PRTSCR screenshots on Gnome. I then realized I had used Gnome Tweak Tool to disable animations. Re-enabling animations and my screenshots are fixed, hope this helps.

I can confirm that it fixes the issue here as well: enabling Animations in Tweak Tool removes the blue tint from screen shots.

1989gironimo commented 4 years ago

I have it enabled and I have regularly the blue tint, so this may be one of the reasons, but not the only one.

bjonnh commented 4 years ago

It happens in Gimp as well (when using selector, not full screen). And I can confirm that re-enabling animations remove the (in my case blue) tint.

grizonic commented 4 years ago

FYI: Enabling animations removes the tint while not using your extension. Also, with the extension I have to set delay times over 2 seconds for the tint to be gone from screenshots taken on my external monitor. Laptop screen is just fine. Thanks for the hard work! Love gnome-shell-screenshot :)

EDIT - Same configuration as 1989gironimo

1989gironimo commented 4 years ago

I was finally able to reproduce this on my laptop with this setup

* use intel graphics

* use wayland backend

* use second monitor

I have exactly this configuration.

Marrosh commented 3 years ago

I noticed I was getting the blue tint in my SHIFT+PRTSCR screenshots on Gnome. I then realized I had used Gnome Tweak Tool to disable animations. Re-enabling animations and my screenshots are fixed, hope this helps.

Indeed, that was the issue. Thank you for good hint which fixed the issue immediately!