search

OttoDIY / OttoNinja

Build your own robot like a Ninja 🐱‍👤 This is the first emotional modular EdTech robot that can walk and roll!
https://www.ottodiy.com/ninja
MIT License
331 stars 214 forks source link

Comments + bugs #42

Closed jaiwiwjwjwisn closed 2 months ago

sfranzyshen commented 2 months ago

Hi jaiwiwjwjwisn! Thank for you submission

I would like to know more about your pull request ... You have not provided any comments to your various commits ... you have 73 commits over 40 files with no info. It is difficult to tell if there are any code changes or just formatting changes. I can not tell from the github diff ... can you help me understand your pull request in a little more detail?

jaiwiwjwjwisn commented 2 months ago

I haven't tested on a physical device, but no changes with main code, just formatting change and some code is shorted i believe

sfranzyshen commented 2 months ago

I haven't tested on a physical device, but no changes with main code, just formatting change and some code is shorted i believe

the pull request, being all lumped together with no comments ... makes it very difficult to follow the changes ... Your interest to improve the current Otto API is welcomed ... and desired ... but maybe we can work together ... and collaborate to easy your ideas into the project ... please join the discord here https://discord.gg/qzFEdweW and then join the discussion for development here https://discord.com/channels/691410809586450483/1228242677963685918

thank you

sfranzyshen commented 2 months ago

Please resubmit with comments and separated into multiple pulls (create a temp branch) to help sort out what you are changing. Thank You