OttoDIY / OttoNinja

Build your own robot like a Ninja 🐱‍👤 This is the first emotional modular EdTech robot that can walk and roll!
https://www.ottodiy.com/ninja
MIT License
331 stars 214 forks source link

Reversed sequence when loading trim values #9

Closed justinotherguy closed 7 years ago

justinotherguy commented 7 years ago

Apparantly the sequence was reversed when loading the trim values from the EEPROM (tested with OTTO_avoid.ino)

cparrapa commented 7 years ago

What do you mean? so far for everyone the sequence was fine maybe you connected the servos in opposite places

justinotherguy commented 7 years ago

I'm pretty sure, I've connected the servos to the correct ports - that comes clearly out of the documentation. I just think that OTTO_calibration.ino stores them in one way and Otto.init in Otto.cpp reads them in another.

So, people will only notice when they use OTTO_calibration.ino. I'll double check, though and let you know.

Sorry about the multi-commit PR - this was unintended. The commits fix 3 seperate issues.

cparrapa commented 7 years ago

please test or maybe better create a new folder with this kind of calibration

justinotherguy commented 7 years ago

I'll close this one now - don't like the fact that the 3 indipendent commits have gone into this one PR. I'll still to verify the single issues.